Repository navigation
Improve handling of non-sdk api calls - #526
Merged
Merged
Conversation
John-David Dalton (jdalton)
pushed a commit
that referenced
this pull request
May 7, 2025
* Improve handling of non-sdk api calls * Update exit code expectation in snapshots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves handling of API calls that do not go through our sdk.
It abstracts the CResult stuff and the .text() and .json() stuff in a way that should always return a CResult.
Also tweaked the meow exit code for emitting help.
Updated the smoke test accordingly. Also added better handling for backing up and restoring certain config values. Just don't ctrl+c too quickly and you'll be fine :)