Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x phpstan #106

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

3.x phpstan #106

wants to merge 2 commits into from

Conversation

ovr
Copy link
Member

@ovr ovr commented Jan 29, 2020

Hey!

Type: code quality

For all OAuth1 providers error as below is shown for getIdentity() method:

Property SocialConnect\OAuth1\AbstractProvider::$consumerToken (SocialConnect\OAuth1\Token) does not accept SocialConnect\Provider\AccessTokenInterface.

for statement

$this->consumerToken = $accessToken;

That's a valid error since SocialConnect\OAuth1\AbstractProvider::$consumerToken property is supposed to be an SocialAuth\OAuth1\Token instance which does not extend the AccessTokenInterface.

I leave it to you to do the needful to fix it 🙂.

Add separate jobs for phpcs and phpstan checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants