Skip to content

Remove obsolete comment in BeefyClient.sol #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vgeddes merged 1 commit into from
Aug 6, 2023
Merged

Remove obsolete comment in BeefyClient.sol #922

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions contracts/src/BeefyClient.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,16 +562,10 @@ contract BeefyClient {
}

/**
* NOTE (SNO-427): This inclusion test is currently insecure because it
* not verify that the supplied merkle leaf index (proof.index) corresponds to the
* leaf being verified.
*
* This was a regression introduced when we merged in an optimized Merkle Proof verifier.
* This new verifier relies on hash pairs being sorted, whereas
* the previous version did not require any sorting.
*
* @dev Checks if a validators address is a member of the merkle tree
* @param account The address of the validator to check
* @param vset The validator set
* @param account The address of the validator to check for inclusion in `vset`.
* @param index The leaf index of the account in the merkle tree of validator set addresses.
* @param proof Merkle proof required for validation of the address
* @return true if the validator is in the set
*/
Expand Down