Conversation
Contributor
* Fix for benchmark & More refactoring * More refactoring * Add const_assert back
3 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lots of cleanups & improvements, mainly around data structures.
For example, its not really necessary to for data structures to use generic types such as
MaxFeeRecipientSize,MaxPubKeySizeMaxSignatureSize, since those will always be 20, 48, and 96 respectively. These constants are very unlikely to change.BoundedVecis only needed for collections that are being written to storage. Otherwise,Vecis fine.SyncCommitteeSizeandSyncCommitteeBitsSizewhere needed.SyncCommittee.pubkeysis now a fixed array instead a vector, since the size of the sync committee is known statically.SyncAggregate.sync_committee_bitsis now a fixed array instead a vector, since the size of the sync committee is known statically.TryFromwithFromin many cases.