Merged
Conversation
yrong
force-pushed
the
ron/polkadot-v0.9.38
branch
from
6ec5118 to
de8206a
Compare
vgeddes
reviewed
Feb 21, 2023
vgeddes
reviewed
Feb 21, 2023
Collaborator
vgeddes
left a comment
vgeddes
left a comment
There was a problem hiding this comment.
Hey @yrong, we don't need really need the test-parachain under parachain/utils/test-parachain anymore, so there is no need to upgrade it.
Instead, what we will do is launch the Statemint parachain in our E2E testnet. But we can handle this in a future PR.
cc @alistair-singh This make sense to you?
Contributor
I agree. |
yrong
force-pushed
the
ron/polkadot-v0.9.38
branch
from
44a9e22 to
6e8069a
Compare
alistair-singh
approved these changes
Mar 3, 2023
* Sync #12857 * Remove test chain * For #12857 * For #12857 * #12857 * Fix build[skip ci] * Workaround for current mmr api * Test CI with foundry * Fix ci breaking * Add cargo fmt to husky & ignore some merkle tests cause ci breaking * Sync dev setup * Revert to use next beefy block * Comment for paritytech/polkadot#6577 * Fix for geth 1.11 * For paritytech/polkadot#6577 * For paritytech/polkadot#6577 * Bump substrate-rpc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
companion with Snowfork/go-substrate-rpc-client#57
also need companion with #780 though we break it for easy review or the beefy bridge will not work