Skip to content

Lodestar 1.4.2 update - #771

Merged
claravanstaden merged 3 commits into
mainfrom
clara/upgrade-lodestar-v1.4.0
Feb 8, 2023
Merged

Lodestar 1.4.2 update#771
claravanstaden merged 3 commits into
mainfrom
clara/upgrade-lodestar-v1.4.0

Conversation

@claravanstaden

Copy link
Copy Markdown
Contributor

Lodestar upgrade. Blocked by an issue where the finalized_header is empty for sync committee updates.

@claravanstaden claravanstaden changed the title Starts with lodestar updates. Lodestar 1.4.0 update Feb 4, 2023
@claravanstaden

Copy link
Copy Markdown
Contributor Author

Fixed by ChainSafe/lodestar#5090. Waiting for Lodestar release 1.4.2 to include the fix.

@yrong

yrong commented Feb 5, 2023

Copy link
Copy Markdown
Contributor

@claravanstaden one issue I met maybe also worth to mention here.

would assume the pr in 1.4.1 also related to the weird issue we met before in some mac os. hope with it no need to hack in /etc/hosts or explicitly adding 127.0.0.1 any more.

@claravanstaden claravanstaden changed the title Lodestar 1.4.0 update Lodestar 1.4.2 update Feb 8, 2023
@claravanstaden
claravanstaden marked this pull request as ready for review February 8, 2023 07:59
@claravanstaden

claravanstaden commented Feb 8, 2023

Copy link
Copy Markdown
Contributor Author

would assume the ChainSafe/lodestar#5073 in 1.4.1 also related to the weird issue we met before in some mac os. hope with it no need to hack in /etc/hosts or explicitly adding 127.0.0.1 any more.

@yrong is this still an issue for you on lodestar 1.4.2? Edit: Looks like it is solved in 1.4.1 but you can perhaps retest and confirm.

@alistair-singh alistair-singh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@claravanstaden

Copy link
Copy Markdown
Contributor Author

I'm going to merge this now because I would like to rebase my ancestry proof branch. I'll address any follow-up comments in a separate PR, if necessary.

@claravanstaden
claravanstaden merged commit 0d67306 into main Feb 8, 2023
@claravanstaden
claravanstaden deleted the clara/upgrade-lodestar-v1.4.0 branch February 8, 2023 09:58
@yrong yrong mentioned this pull request Feb 10, 2023
3 tasks
@yrong

yrong commented Feb 10, 2023

Copy link
Copy Markdown
Contributor

is this still an issue for you on lodestar 1.4.2? Edit: Looks like it is solved in 1.4.1 but you can perhaps retest and confirm.

Sorry for the late response and yes it works in my setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants