Skip to content

Fix breaking smoke tests #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yrong merged 8 commits into from
May 20, 2025
Merged

Fix breaking smoke tests #1472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
24cbc18
Update smoke tests
yrong May 12, 2025
a7149e1
Update to recent release v0.42.1
yrong May 12, 2025
f75fd34
Fix ethereum relay
yrong May 14, 2025
b6e760f
Improve E2E scripts & Fix inbound tests
yrong May 15, 2025
ec89fdb
Merge branch 'main' into ron/upgrade-smoke-test
yrong May 16, 2025
cc86a7a
Fix format
yrong May 19, 2025
399e0c1
Fix transact
yrong May 19, 2025
20f1562
Update bindings
yrong May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
147 changes: 146 additions & 1 deletion relayer/contracts/gateway.go
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions relayer/relays/execution/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ func (r *Relay) fetchUnprocessedParachainNonces(latest uint64) ([]uint64, error)
latestBucket := latest / 128

for b := uint64(0); b <= latestBucket; b++ {
encodedBucket, err := types.EncodeToBytes(types.NewU128(*big.NewInt(int64(b))))
encodedBucket, err := types.EncodeToBytes(types.NewU64(b))
Copy link
Copy Markdown
Contributor

@alistair-singh alistair-singh May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this related to the subxt change?

Copy link
Copy Markdown
Contributor Author

@yrong yrong May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, it's to coordinate with paritytech/polkadot-sdk#8240, which includes an optimized SparseBitmap.

Copy link
Copy Markdown
Contributor

@claravanstaden claravanstaden May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you @yrong!

bucketKey, _ := types.CreateStorageKey(
r.paraconn.Metadata(),
"EthereumInboundQueueV2",
Expand Down Expand Up @@ -261,7 +261,7 @@ func (r *Relay) isParachainNonceSet(index uint64) (bool, error) {
bucket := index / 128
bitPosition := index % 128

encodedBucket, err := types.EncodeToBytes(types.NewU128(*big.NewInt(int64(bucket))))
encodedBucket, err := types.EncodeToBytes(types.NewU64(bucket))
bucketKey, err := types.CreateStorageKey(r.paraconn.Metadata(), "EthereumInboundQueueV2", "NonceBitmap", encodedBucket)
if err != nil {
return false, fmt.Errorf("create storage key for EthereumInboundQueueV2.NonceBitmap: %w", err)
Expand Down
Loading
Loading