Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo cleanup and renames #1106

Merged
merged 22 commits into from
Jan 10, 2024
Merged

Cargo cleanup and renames #1106

merged 22 commits into from
Jan 10, 2024

Conversation

claravanstaden
Copy link
Contributor

@claravanstaden claravanstaden commented Jan 10, 2024

Polkadot-sdk: Snowfork/polkadot-sdk#94

@claravanstaden claravanstaden mentioned this pull request Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (e0506f7) 76.36% compared to head (dded151) 75.08%.

Files Patch % Lines
parachain/pallets/ethereum-client/src/impls.rs 0.00% 6 Missing ⚠️
parachain/runtime/test-common/src/lib.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1106      +/-   ##
==========================================
- Coverage   76.36%   75.08%   -1.29%     
==========================================
  Files          56       58       +2     
  Lines        2344     2384      +40     
  Branches       72       72              
==========================================
  Hits         1790     1790              
- Misses        537      577      +40     
  Partials       17       17              
Flag Coverage Δ
rust 73.96% <7.69%> (-1.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@claravanstaden claravanstaden marked this pull request as ready for review January 10, 2024 09:36
@claravanstaden
Copy link
Contributor Author

Addresses comments in paritytech/polkadot-sdk#2894.

Copy link
Collaborator

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@claravanstaden claravanstaden merged commit fe1bdf4 into main Jan 10, 2024
9 checks passed
@claravanstaden claravanstaden deleted the cargo-cleanup-and-renames branch January 10, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants