Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coverage #115

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Fix coverage #115

merged 2 commits into from
Feb 22, 2024

Conversation

claravanstaden
Copy link
Collaborator

@claravanstaden claravanstaden commented Feb 20, 2024 •
edited
Loading

  • Fixes the code coverage (it didn't run on the default snowbridge branch)
  • Fixes some minor issues with the contribute upstream script

@claravanstaden claravanstaden marked this pull request as ready for review February 20, 2024 10:19
@claravanstaden
Copy link
Collaborator Author

Code coverage report is not shown here but it looks like coverage should first run on the default branch (snowbridge) before it will show on PRs.

vgeddes
vgeddes approved these changes Feb 20, 2024
View reviewed changes
Copy link

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

yrong
yrong approved these changes Feb 21, 2024
View reviewed changes
Copy link

@yrong yrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@claravanstaden claravanstaden merged commit 4cede80 into snowbridge Feb 22, 2024
7 checks passed
@claravanstaden claravanstaden deleted the minor-improvements branch February 22, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgeddes vgeddes vgeddes approved these changes

@yrong yrong yrong approved these changes

@alistair-singh alistair-singh Awaiting requested review from alistair-singh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@claravanstaden @vgeddes @yrong