Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Overview of the grant ownership resource #3342

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

chore: Overview of the grant ownership resource #3342

wants to merge 1 commit into from
+290 −2

Conversation

sfc-gh-jcieslak
Copy link
Collaborator

Changes

  • Add a new grant ownership overview document in
    • the technical_documentation directory
    • guides directory that will be published to the registry
    • added link form the grant_ownership documentation to the guide placed in the registry

@sfc-gh-asawicki sfc-gh-asawicki changed the base branch from main to dev January 17, 2025 15:00
sfc-gh-jmichalak
sfc-gh-jmichalak reviewed Jan 17, 2025
View reviewed changes
templates/resources/grant_ownership.md.tmpl
@@ -10,7 +10,7 @@ description: |-
{{- end }}
---

~> **Note** For more details about granting ownership, please visit [`GRANT OWNERSHIP` Snowflake documentation page](https://docs.snowflake.com/en/sql-reference/sql/grant-ownership).
~> **Note** For more details about granting ownership, please visit [`GRANT OWNERSHIP` Snowflake documentation page](https://docs.snowflake.com/en/sql-reference/sql/grant-ownership), and our recently published [grant ownership resource overview](https://registry.terraform.io/providers/Snowflake-Labs/snowflake/latest/docs/guides/grant_ownership_resource_overview).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Pls remove recently. Also, use a permalink.

docs/technical-documentation/grant_ownership_resource_overview.md
@@ -0,0 +1,92 @@
# Grant ownership summary

The [grant\_ownership resource](https://registry.terraform.io/providers/Snowflake-Labs/snowflake/latest/docs/resources/grant_ownership) was introduced in version 0.88.0.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we publish it in both directories?

@github-actions GitHub Actions
Copy link

Integration tests failure for ea0b3f647662c0fd3290a7956449e1fa7a40721f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jmichalak sfc-gh-jmichalak sfc-gh-jmichalak left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-jcieslak @sfc-gh-jmichalak