Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: downgrade mattn/go-ieproxy #1016

Merged
merged 1 commit into from
May 25, 2022
Merged

fix: downgrade mattn/go-ieproxy #1016

merged 1 commit into from
May 25, 2022

Conversation

sfc-gh-swinkler
Copy link
Collaborator

getting error message with mattn during release

   ⨯ release failed after 14.48s error=failed to build for darwin_arm64: exit status 2: # github.com/mattn/go-ieproxy
../../../../pkg/mod/github.com/mattn/[email protected]/ieproxy.go:36:9: undefined: getConf
../../../../pkg/mod/github.com/mattn/[email protected]/ieproxy.go:41:9: undefined: reloadConf
../../../../pkg/mod/github.com/mattn/[email protected]/ieproxy.go:48:2: undefined: overrideEnvWithStaticProxy
../../../../pkg/mod/github.com/mattn/[email protected]/ieproxy.go:53:12: psc.findProxyForURL undefined (type *ProxyScriptConf has no field or method findProxyForURL, but does have FindProxyForURL)

downgrading to version 0.1 which seems to work as per: google/go-cloud#3114

Test Plan

  • acceptance tests
  • …

References

@sfc-gh-swinkler sfc-gh-swinkler changed the title chore: downgrade mattn/go-ieproxy fix: downgrade mattn/go-ieproxy May 25, 2022
@github-actions
Copy link

Integration tests success for d1d4a2da5ee1f5a594afe81c303878d497d39814

@sfc-gh-swinkler sfc-gh-swinkler merged commit 704ce1f into main May 25, 2022
@sfc-gh-swinkler sfc-gh-swinkler deleted the mattn-update branch May 25, 2022 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jalin sfc-gh-jalin sfc-gh-jalin approved these changes

@alldoami alldoami Awaiting requested review from alldoami

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-swinkler @sfc-gh-jalin