Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/11 #109

Open
wants to merge 23 commits into
base: develop
Choose a base branch
from
Open

Feature/11 #109

wants to merge 23 commits into from

Conversation

kjugi
Copy link
Contributor

@kjugi kjugi commented Dec 10, 2018

Adding translations support by vuei18n package

Resolves #11

@kjugi kjugi self-assigned this Dec 10, 2018
@kjugi kjugi requested a review from szafran89 December 10, 2018 17:11
view/frontend/templates/onepage.phtml Show resolved Hide resolved
view/frontend/web/js/data/translations.json Outdated Show resolved Hide resolved
import Vuei18n from 'vue-i18n'

import defaultMessages from '../data/translations-en_US.json'
import plMessages from '../data/translations-pl_PL.json'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just import one lang which we use?

view/frontend/web/js/data/translations-pl_PL.json Outdated Show resolved Hide resolved
view/frontend/web/js/data/translations-en_US.json Outdated Show resolved Hide resolved
.babelrc Outdated Show resolved Hide resolved
@szafran89
Copy link
Contributor

please resolve conflicts as well

"Shipping Methods": "Metody wysyłki",
"Product List": "Lista produktów",
"Product Name": "Nazwa produktu:",
"Price": "Cena:",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add : to Price or remove from Cena

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants