Skip to content

#104299 - Updated snowdog-menu block id #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from
Open

#104299 - Updated snowdog-menu block id #309

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
f29e935
#104299 - Updated snowdog-menu block id
Jan 17, 2024
25748fb
Use method to get id column name
Jan 18, 2024
8a1ab1f
Remove trailing comma
Jan 18, 2024
ecb329d
Resolve pipeline issue
Jan 18, 2024
525e4e9
Get link field
Jan 19, 2024
b494539
Remove trailing comma
Jan 19, 2024
6d18257
Get row id for nodes
Jan 19, 2024
186f5d2
Updated column name
Jan 22, 2024
a175531
Get nodes by menu's row_id
Jan 22, 2024
25166d4
Get serialized node data for scheduler
Jan 24, 2024
7b53861
Added helper to get link field for menu
Jan 26, 2024
261c712
Removed trailing comma
Jan 26, 2024
32ec3df
Get menu by link field
Jan 26, 2024
1081f08
Revert changes in PageActions class
Feb 6, 2024
f3f6fcd
Updated actions to duplicate, export and import menus
Feb 6, 2024
87c8b21
Get menu row_id for import and export actions
Feb 8, 2024
cab6eb7
#104299 - get serialized nodes input name from config
ofrankowska Apr 3, 2024
b796c9e
#104299 - remove unused config.el
ofrankowska Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions view/adminhtml/templates/menu/nodes.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ $blockHtmlId = $block->getBlockHtmlId();
"imageDeleteUrl" : "<?= $block->getImageDeleteUrl() ?>",
"imageUploadFileId": "<?= $block->getImageUploadFileId() ?>",
"lazyMinItemsCount": "1000",
"serializedNodesElementName": "serialized_nodes",
Copy link
Contributor

@ofrankowska ofrankowska Apr 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: pass the correct value from backend (either "serialized_nodes" or "snowmenu_staging_serialized_nodes")

"translation": {
"nodes" : "<?= __('Nodes') ?>",
"click" : "<?= __('Click') ?>",
Expand Down
21 changes: 4 additions & 17 deletions view/adminhtml/web/vue/app.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,7 @@
},
watch: {
jsonList: function (newValue) {
this.updateSerializedNodes(newValue)
this.updateMenuStagingSerializedNodes(newValue);
this.updateSerializedNodes(newValue);
}
},
mounted () {
Expand All @@ -110,14 +109,10 @@
};

// while loaded set JSON list as a value
checkElement('[name="serialized_nodes"]').then(() => {
this.list = this.nodes.map(item => setUuidRecursive(item))
checkElement(`[name='${this.config.serializedNodesElementName}']`).then(() => {
this.list = this.nodes.map(item => setUuidRecursive(item));
this.updateSerializedNodes(this.jsonList);
});
checkElement('[name="snowmenu_staging_serialized_nodes"]').then(() => {
this.list = this.nodes.map(item => setUuidRecursive(item))
this.updateMenuStagingSerializedNodes(this.jsonList);
});
},
methods: {
uuid,
Expand Down Expand Up @@ -148,20 +143,12 @@
},
updateSerializedNodes(value) {
const updateEvent = new Event('change');
const serializedNodeInput = document.querySelector('[name="serialized_nodes"]');
const serializedNodeInput = document.querySelector(`[name='${this.config.serializedNodesElementName}']`);
// update serialized_nodes input value
serializedNodeInput.value = value;
// trigger change event to set value
serializedNodeInput.dispatchEvent(updateEvent);
},
updateMenuStagingSerializedNodes(value) {
const updateEvent = new Event('change');
const serializedNodeInput = document.querySelector('[name="snowmenu_staging_serialized_nodes"]');
// update serialized_nodes input value
serializedNodeInput.value = value;
// trigger change event to set value
serializedNodeInput.dispatchEvent(updateEvent);
}
},
template: template
});
Expand Down