Feature/disable prod minification #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Igloczek
suggested changes
May 12, 2017
config/themes.json.sample
Outdated
| @@ -26,6 +26,7 @@ | |||
| "parent": "blank", | |||
| "stylesDir": "web/css", | |||
| "postcss": ["plugins.autoprefixer()"], | |||
| "disableSuffix": "true", | |||
There was a problem hiding this comment.
true should be a boolean, not string.
There was a problem hiding this comment.
Woops. Adjusted to a boolean
helper/scss.js
Outdated
| @@ -5,7 +5,8 @@ module.exports = function(gulp, plugins, config, name, file) { // eslint-disable | |||
| stylesDir = theme.stylesDir ? theme.stylesDir : 'styles', | |||
| disableMaps = plugins.util.env.disableMaps || false, | |||
| production = plugins.util.env.prod || false, | |||
| postcss = []; | |||
| postcss = [], | |||
| disableSuffix = theme.disableSuffix ? true : false; | |||
There was a problem hiding this comment.
It can be reduced to theme.disableSuffix || false also keep the same aligning of = as above.
There was a problem hiding this comment.
I shifted them all 1 more indent since the linter complained about 8 and not 6 spaces
Igloczek
approved these changes
May 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Production mode
--prodadds a .min suffix which breaks frontend CSS if you do not have the Minify CSS Files admin configuration setting turned on. For various reasons, we may not want to turn it on but still be able to rungulp stylesin production mode. This PR adds a theme config option to disable adding a filename suffix (.min) on a per theme basis.Simply add
to the themes.json file and .min won't be appended in production mode.
Maybe there is a better approach but this is what I came up with for now.