-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/53585 Migrate cookie message #187
base: develop
Are you sure you want to change the base?
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://alpaca-ui-git-feature-53585.snowdog1.now.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- In
CookieMessage.js
line 59 we havedocument
, but to avoid ssr problems I think we should change it to:
const focusable = this.$root.$el.querySelectorAll('button:not([disabled]), a[href], area[href] input:not([disabled]), select:not([disabled]), textarea:not([disabled]), *[tabindex]:not([tabindex="-1"]), object, embed, *[contenteditable]')
Also this focusable list should be defined after this.isOpen = false
, because now cookie itself is the first item to be focused
components/src/molecules/cookie-message/CookieMessage.stories.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
components/src/molecules/cookie-message/CookieMessage.stories.js
Outdated
Show resolved
Hide resolved
components/src/molecules/cookie-message/CookieMessage.stories.js
Outdated
Show resolved
Hide resolved
components/src/molecules/cookie-message/CookieMessage.stories.js
Outdated
Show resolved
Hide resolved
components/src/molecules/cookie-message/CookieMessage.stories.js
Outdated
Show resolved
Hide resolved
components/src/molecules/cookie-message/CookieMessage.stories.js
Outdated
Show resolved
Hide resolved
components/src/molecules/cookie-message/CookieMessage.stories.js
Outdated
Show resolved
Hide resolved
color: $cookie-message__close-color; | ||
background: none; | ||
|
||
.a-cookie-message__close-icon { | ||
transition: $cookie-message__close-icon-transition; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this transition to &__close-icon
styles, now the transition effect works only in one-way
# Conflicts: # components/src/03-modules/footer/Footer.js
sth wrong with line spaces, probably line-height http://prntscr.com/nvu3l7 |
No description provided.