Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/53585 Migrate cookie message #187

Open
wants to merge 30 commits into
base: develop
Choose a base branch
from
Open

Feature/53585 Migrate cookie message #187

wants to merge 30 commits into from

Conversation

jszczech
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented May 20, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://alpaca-ui-git-feature-53585.snowdog1.now.sh

@vercel vercel bot requested a deployment to staging May 21, 2019 09:01 Abandoned
@vercel vercel bot requested a deployment to staging May 21, 2019 09:01 Abandoned
@vercel vercel bot requested a deployment to staging May 21, 2019 09:02 Abandoned
Copy link
Member

@Aekal Aekal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • In CookieMessage.js line 59 we have document, but to avoid ssr problems I think we should change it to:
const focusable = this.$root.$el.querySelectorAll('button:not([disabled]), a[href], area[href] input:not([disabled]), select:not([disabled]), textarea:not([disabled]), *[tabindex]:not([tabindex="-1"]), object, embed, *[contenteditable]')

Also this focusable list should be defined after this.isOpen = false, because now cookie itself is the first item to be focused

@vercel vercel bot temporarily deployed to staging May 21, 2019 16:10 Inactive
Copy link
Member

@Aekal Aekal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please also fix hover and focus styles on button
    Zrzut ekranu 2019-05-22 o 10 17 33
  • The icon is not highlighted on button hover

components/src/molecules/cookie-message/CookieMessage.scss Outdated Show resolved Hide resolved
color: $cookie-message__close-color;
background: none;

.a-cookie-message__close-icon {
transition: $cookie-message__close-icon-transition;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this transition to &__close-icon styles, now the transition effect works only in one-way

components/src/molecules/cookie-message/CookieMessage.scss Outdated Show resolved Hide resolved
Joanna Szczęch added 3 commits May 28, 2019 04:42
@szafran89
Copy link
Contributor

sth wrong with line spaces, probably line-height http://prntscr.com/nvu3l7

@vercel vercel bot temporarily deployed to staging June 4, 2019 08:30 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants