Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PostgreSQL #131

Merged
merged 9 commits into from
Jan 27, 2025
Merged

Support PostgreSQL #131

merged 9 commits into from
Jan 27, 2025

Conversation

SIMULATAN
Copy link
Contributor

@SIMULATAN SIMULATAN commented Jan 13, 2025

it's that time of the year again, the 3rd database switch is due.
surely that'll fix all issues..?

Todo

  • verify that EntityStates work
    the unit test uses a.. special initialization method, therefore, it is not guaranteed that the codecs will actually exist and work at run time.. sigh

@Copilot Copilot bot review requested due to automatic review settings January 13, 2025 14:03

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 59 out of 79 changed files in this pull request and generated no comments.

Files not reviewed (20)
  • adapter/mongodb/src/main/kotlin/me/snoty/backend/database/mongo/MongoConfig.kt: Language not supported
  • adapter/mongodb/src/main/kotlin/me/snoty/backend/database/mongo/MongoStartup.kt: Language not supported
  • adapter/mongodb/src/main/kotlin/me/snoty/backend/database/mongo/MongoUtils.kt: Language not supported
  • adapter/mongodb/src/main/kotlin/me/snoty/backend/database/mongo/migrations/impl/MigrateNodeDescriptorNamespaceName.kt: Language not supported
  • adapter/mongodb/src/main/kotlin/me/snoty/backend/integration/MongoEntityStateService.kt: Language not supported
  • adapter/mongodb/src/main/kotlin/me/snoty/backend/integration/config/MongoNodeFilters.kt: Language not supported
  • adapter/mongodb/src/main/kotlin/me/snoty/backend/integration/config/MongoNodeService.kt: Language not supported
  • adapter/mongodb/src/main/kotlin/me/snoty/backend/wiring/flow/MongoFlowManagementService.kt: Language not supported
  • adapter/mongodb/src/main/kotlin/me/snoty/backend/wiring/flow/MongoFlowService.kt: Language not supported
  • adapter/mongodb/src/main/kotlin/me/snoty/backend/wiring/flow/execution/MongoFlowExecutionService.kt: Language not supported
  • adapter/mongodb/src/main/kotlin/me/snoty/backend/wiring/flow/import/MongoFlowImportService.kt: Language not supported
  • adapter/mongodb/src/main/kotlin/me/snoty/backend/wiring/node/MongoNode.kt: Language not supported
  • adapter/mongodb/src/main/kotlin/me/snoty/backend/wiring/node/MongoSettingsService.kt: Language not supported
  • adapter/mongodb/src/testIntegration/kotlin/me/snoty/backend/database/mongo/MongoTest.kt: Language not supported
  • adapter/mongodb/src/testIntegration/kotlin/me/snoty/backend/wiring/MongoEntityStateServiceTest.kt: Language not supported
  • adapter/mongodb/src/testIntegration/kotlin/me/snoty/backend/wiring/flow/MongoFlowServiceTest.kt: Language not supported
  • adapter/mongodb/src/testIntegration/kotlin/me/snoty/backend/wiring/flow/MongoNodeServiceTest.kt: Language not supported
  • adapter/mongodb/src/testIntegration/kotlin/me/snoty/backend/wiring/node/MongoNodeServiceTest.kt: Language not supported
  • adapter/sql/build.gradle.kts: Language not supported
  • adapter/sql/src/main/kotlin/me/snoty/backend/database/sql/SqlConfig.kt: Language not supported
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 35.89342% with 409 lines in your changes missing coverage. Please review.

Project coverage is 23.90%. Comparing base (2e1140b) to head (9876464).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...d/wiring/flow/execution/SqlFlowExecutionService.kt 0.00% 72 Missing ⚠️
...ackend/database/utils/SqlNodePersistenceService.kt 0.00% 38 Missing ⚠️
...wiring/flow/execution/MongoFlowExecutionService.kt 0.00% 34 Missing ⚠️
...lin/me/snoty/backend/wiring/node/SqlNodeService.kt 57.89% 29 Missing and 3 partials ⚠️
...backend/wiring/flow/import/SqlFlowImportService.kt 0.00% 22 Missing ⚠️
.../kotlin/me/snoty/backend/database/sql/SqlConfig.kt 0.00% 21 Missing ⚠️
...ackend/wiring/flow/execution/FlowExecutionTable.kt 0.00% 18 Missing ⚠️
...lin/me/snoty/backend/wiring/flow/SqlFlowService.kt 59.52% 17 Missing ⚠️
...ty/backend/database/utils/SqlEntityStateService.kt 65.90% 13 Missing and 2 partials ⚠️
...ration/common/wiring/flow/FlowManagementService.kt 0.00% 13 Missing ⚠️
... and 31 more
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   22.22%   23.90%   +1.68%     
==========================================
  Files         264      288      +24     
  Lines        4153     4618     +465     
  Branches      501      533      +32     
==========================================
+ Hits          923     1104     +181     
- Misses       3150     3421     +271     
- Partials       80       93      +13     
Files with missing lines Coverage Δ
...tlin/me/snoty/backend/database/mongo/MongoUtils.kt 36.36% <100.00%> (+6.36%) ⬆️
...rations/impl/MigrateNodeDescriptorNamespaceName.kt 0.00% <ø> (ø)
...oty/backend/integration/config/MongoNodeFilters.kt 78.57% <ø> (ø)
...n/me/snoty/backend/database/sql/SqlDbExtensions.kt 100.00% <100.00%> (ø)
...e/snoty/backend/database/utils/EntityStateTable.kt 100.00% <100.00%> (ø)
...rc/main/kotlin/me/snoty/backend/utils/UuidUtils.kt 100.00% <100.00%> (ø)
...n/kotlin/me/snoty/backend/wiring/node/NodeTable.kt 100.00% <100.00%> (ø)
...lin/me/snoty/backend/wiring/node/SqlNodeFilters.kt 100.00% <100.00%> (ø)
.../src/main/kotlin/me/snoty/backend/config/Config.kt 100.00% <ø> (ø)
...n/me/snoty/backend/scheduling/FlowTriggerReason.kt 100.00% <100.00%> (+28.57%) ⬆️
... and 53 more

... and 2 files with indirect coverage changes

@SIMULATAN SIMULATAN force-pushed the feat/support-postgres branch 3 times, most recently from 62c6024 to 57069f9 Compare January 27, 2025 19:16
@SIMULATAN SIMULATAN force-pushed the feat/support-postgres branch from 57069f9 to 9876464 Compare January 27, 2025 21:30
@SIMULATAN SIMULATAN merged commit a0b10ad into main Jan 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant