Add 'run_if_exists' so we can '''cache''' bq results #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmontemayor2-sc
requested review from
mkolodner-sc,
nshah-sc,
svij-sc,
xgao4-sc,
yliu2-sc and
zfan3-sc
as code owners
yliu2-sc
reviewed
Sep 29, 2025
| logger.exception(f"Could not run query: {e}") | ||
| raise e | ||
|
|
||
| def run_if_exists( |
There was a problem hiding this comment.
I think BQ already check this if you don't set your write_disposition to WRITE_TRUNCATE and it's default to WRITE_EMPTY
There was a problem hiding this comment.
BQ returns an error 1. I don't think we want to error out in this case.
We could modify the code otherwise but I think there's use in having the name be different
There was a problem hiding this comment.
shouldn't the function name be run_query_if_not_table_exists instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed offline, we can add this to "easily" cache some bq table outputs.
This is a very naive cacheing strategy, and needs to asusme the bq table doesn't get modified, but since many of our usecases are like:
Using this should be "safe" in many circumstances.