Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input: reset pointer image on leave #1340

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Conversation

cmeissl
Copy link
Collaborator

@cmeissl cmeissl commented Feb 24, 2024

when nothing is focused we need to reset the cursor image. this has been accidentally removed during touch re-factor.
before the touch re-factor the cursor would have been reset whenever the focus changes, but it should be fine to
only reset it when there is no focus at all.

From the spec:

When a seat's focus enters a surface, the pointer image is undefined and a client should respond to this event by setting an appropriate pointer image with the set_cursor request.

when nothing is focused we need to
reset the cursor image. this has been
accidentally removed during touch
re-factor.
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.55%. Comparing base (a04d9ac) to head (5386601).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1340      +/-   ##
==========================================
+ Coverage   20.53%   20.55%   +0.01%     
==========================================
  Files         158      158              
  Lines       25867    25868       +1     
==========================================
+ Hits         5313     5317       +4     
+ Misses      20554    20551       -3     
Flag Coverage Δ
wlcs-buffer 17.96% <0.00%> (-0.01%) ⬇️
wlcs-core 17.62% <0.00%> (-0.01%) ⬇️
wlcs-output 7.53% <0.00%> (-0.01%) ⬇️
wlcs-pointer-input 19.43% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmeissl cmeissl marked this pull request as ready for review February 24, 2024 08:38
@Drakulix Drakulix merged commit b62ced7 into master Feb 24, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants