Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace deprecated(broken) nerd font icon #58

Merged
merged 1 commit into from
May 28, 2023

Conversation

qazxcdswe123
Copy link
Contributor

@qazxcdswe123 qazxcdswe123 commented May 22, 2023

Some codepoints conflict with other fonts (especially CJK fonts). To ensure that the icons remain in the private use area, Nerd Fonts has changed the codepoints of some icons in recent releases, for example, nf-mdi-* icons (including over 2,000 icons) are deprecated since v2.3.3 and will be removed in v3.

See https://github.com/loichyan/nerdfix

This commit replace nf-mdi with nf-md

Before:
image

After:
image

See also: https://github.com/nvim-neo-tree/neo-tree.nvim#configuration-for-nerd-fonts-v3-users

Copy link
Owner

@SmiteshP SmiteshP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also make changes in README and help docs. Thanks :)

> Some codepoints conflict with other fonts (especially CJK fonts). To ensure that the icons remain in the private use area, Nerd Fonts has changed the codepoints of some icons in recent releases, for example, nf-mdi-* icons (including over 2,000 icons) are deprecated since v2.3.3 and will be removed in v3.

See https://github.com/loichyan/nerdfix

This commit replace nf-mdi with nf-md
@qazxcdswe123
Copy link
Contributor Author

Done

Copy link
Owner

@SmiteshP SmiteshP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

@SmiteshP SmiteshP merged commit 0db1d62 into SmiteshP:master May 28, 2023
@SmiteshP SmiteshP mentioned this pull request Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants