Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the implemented interface of the Elasticsuite Search Engine. #873

Merged

Conversation

romainruaud
Copy link
Collaborator

This one is a pre-requisite for fixing #855

This is just changing the implemented interface from \Magento\Framework\Api\Search\SearchInterface to \Magento\Search\Api\SearchInterface.

The \Magento\Search\Api\SearchInterface is an @api flagged one also, and is empty and just inheriting the \Magento\Framework\Api\Search\SearchInterface : https://github.com/magento/magento2/blob/2.2-develop/app/code/Magento/Search/Api/SearchInterface.php

So for me, this is not too much risky to inherit this interface instead of the previous one, since they are the same for now. Also, the new interface is part of the Magento_Search module but we already depend on it.

Regards

@romainruaud
Copy link
Collaborator Author

It's also more logical to implement this interface since this is the one we declared on our config here : https://github.com/Smile-SA/elasticsuite/blob/master/src/module-elasticsuite-core/etc/di.xml#L65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants