Change the implemented interface of the Elasticsuite Search Engine. #873
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is a pre-requisite for fixing #855
This is just changing the implemented interface from
\Magento\Framework\Api\Search\SearchInterface
to\Magento\Search\Api\SearchInterface
.The
\Magento\Search\Api\SearchInterface
is an@api
flagged one also, and is empty and just inheriting the\Magento\Framework\Api\Search\SearchInterface
: https://github.com/magento/magento2/blob/2.2-develop/app/code/Magento/Search/Api/SearchInterface.phpSo for me, this is not too much risky to inherit this interface instead of the previous one, since they are the same for now. Also, the new interface is part of the
Magento_Search
module but we already depend on it.Regards