Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store level merchandiser feature #1247

Merged
merged 1 commit into from
Jan 16, 2019
Merged

Store level merchandiser feature #1247

merged 1 commit into from
Jan 16, 2019

Conversation

rbayet
Copy link
Collaborator

@rbayet rbayet commented Jan 6, 2019

TODO :

  • decide if we want to finalize and merge POC search in category product preview #1183 first (they will conflict ...) ?
  • initialize store-level positions and blacklist as a copy of global/default positions and blacklist on first override (instead of resetting everything) + reset button ?
  • at least french i18n
  • extra tests (on CE and single store instances)

@rbayet rbayet force-pushed the feat_store_level_visual_merch branch 11 times, most recently from fe6b085 to 68a913f Compare January 10, 2019 17:31
@rbayet
Copy link
Collaborator Author

rbayet commented Jan 11, 2019

TODO :

  • decide if we want to finalize and merge POC search in category product preview #1183 first (they will conflict ...) ?
  • initialize store-level positions and blacklist as a copy of global/default positions and blacklist on first override (instead of resetting everything) + reset button ?
  • at least french i18n
  • extra tests (on CE and single store instances)

@rbayet rbayet force-pushed the feat_store_level_visual_merch branch 4 times, most recently from 097b337 to 4a2210f Compare January 11, 2019 18:24
@rbayet
Copy link
Collaborator Author

rbayet commented Jan 11, 2019

TODO :

  • decide if we want to finalize and merge POC search in category product preview #1183 first (they will conflict ...) ?
  • initialize store-level positions and blacklist as a copy of global/default positions and blacklist on first override (instead of resetting everything) + reset button ?
  • at least french i18n
  • extra tests (on CE and single store instances)
    • minor fix where the default/All Store Views positions and blacklist are not correctly previewed when a category is edited in a specific store view context (toggle on and off the preview/editing mode corrects the preview)

@rbayet rbayet force-pushed the feat_store_level_visual_merch branch from 10ee3ed to 7178170 Compare January 13, 2019 17:35
@rbayet
Copy link
Collaborator Author

rbayet commented Jan 13, 2019

TODO :

  • decide if we want to finalize and merge POC search in category product preview #1183 first (they will conflict ...) ?
  • initialize store-level positions and blacklist as a copy of global/default positions and blacklist on first override (instead of resetting everything) + reset button ?
  • at least french i18n
  • extra tests (on CE and single store instances)
    • minor fix where the default/All Store Views positions and blacklist are not correctly previewed when a category is edited in a specific store view context (toggle on and off the preview/editing mode corrects the preview)
  • slight UI changes

@romainruaud
Copy link
Collaborator

OK for me on my Magento 2.2

@romainruaud
Copy link
Collaborator

I let you merge and cascade this one

@rbayet rbayet force-pushed the feat_store_level_visual_merch branch from 7178170 to d3d1602 Compare January 16, 2019 10:23
@rbayet rbayet changed the title [WIP] Store level merchandiser Store level merchandiser feature Jan 16, 2019
@rbayet rbayet merged commit 933a9f3 into Smile-SA:2.6.x Jan 16, 2019
@rbayet rbayet deleted the feat_store_level_visual_merch branch March 1, 2019 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romainruaud romainruaud romainruaud approved these changes

Assignees

@rbayet rbayet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbayet @romainruaud