Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catalog module depend on Magento_CatalogGraphQl #1894

Closed
Coosos opened this issue Jul 29, 2020 · 0 comments
Closed

Catalog module depend on Magento_CatalogGraphQl #1894

Coosos opened this issue Jul 29, 2020 · 0 comments
Assignees
@romainruaud
Labels
enhancement

Comments

@Coosos
Copy link
Contributor

Coosos commented Jul 29, 2020

module-elasticsuite-catalog depend on Magento_CatalogGraphQl while this one seems to contain nothing from graphql.
Piece of code forgotten following the creation of the module module-elasticsuite-catalog-graph-ql ?

https://github.com/Smile-SA/elasticsuite/blob/2.9.x/src/module-elasticsuite-catalog/etc/module.xml

Preconditions

ElasticSuite Version : 2.9
@romainruaud romainruaud self-assigned this Aug 3, 2020
romainruaud added a commit that referenced this issue Aug 3, 2020
@romainruaud
Merge pull request #1907 from romainruaud/fix_catalog-module-dependen…
cb25f1f 
…cies

Fix #1894 remove dependency to CatalogGraphQl module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romainruaud romainruaud

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Coosos @romainruaud