Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message when more than 20 messages #32

Closed
skin27 opened this issue Sep 8, 2023 · 2 comments · Fixed by #36
Closed

Error message when more than 20 messages #32

skin27 opened this issue Sep 8, 2023 · 2 comments · Fixed by #36
Labels
bug Something isn't working

Comments

@skin27
Copy link

skin27 commented Sep 8, 2023

I have just taken over managing a GitHub Workflow from a colleague. One of the first thing I did was to add a job to delete, a few more packages (so now there are 39 packages). Then I run into an error and found out that the action works at most with 20 packages. From your readme:

"The action works by getting at most 20 packages with at most the oldest 100 versions of each, applying the filters (see table below) on them and then deleting the matching versions."

My questions:

  1. Why is this limit there? Isn't 20 a bit low?
  2. Isn't it better to check if the limit is exceeded before the action is run and then report a readable error? Something like: "Maximum number of package names is exceeded. 39 package names are listed, but a maximum of 20 is allowed".

In the attached log file the error I now see.
delete_old_packages_error.log

@rubengees
Copy link
Member

Hi, thanks for using this action,

  1. I think this is a limit we had for historical reasons and is not actually needed anymore.
  2. The error you posted seems to be the code of this action? is this really what is printed?

In any case, I will check this later and remove the check!

@rubengees rubengees added the bug Something isn't working label Sep 11, 2023
@skin27
Copy link
Author

skin27 commented Sep 12, 2023

Yeah, the whole code was what printed. When I could use more than 20 than would be fine too. Keep up the good work.

tisoft added a commit to advanova/delete-old-packages that referenced this issue Oct 26, 2023
tisoft added a commit to advanova/delete-old-packages that referenced this issue Oct 26, 2023
rubengees pushed a commit that referenced this issue Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants