Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix slimefun block turning into a vanilla block if there are viewers #4101

Conversation

J3fftw1
Copy link
Contributor

@J3fftw1 J3fftw1 commented Jan 17, 2024

Description

when a slimefun block with an inventory has a viewer and gets broken it turns into a vanilla item.

Proposed changes

Changed the for loop.

Related Issues (if applicable)

https://paste.walshy.dev/pS31PJ6GnlJy

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@J3fftw1 J3fftw1 requested a review from a team as a code owner January 17, 2024 15:54
@github-actions github-actions bot added the ✨ Fix This Pull Request fixes an issue. label Jan 17, 2024
Copy link
Contributor

Your Pull Request was automatically labelled as: "✨ Fix"
Thank you for contributing to this project! ❤️

Copy link
Contributor

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 9bc350c6

https://preview-builds.walshy.dev/download/Slimefun/4101/9bc350c6

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

Copy link
Contributor

@JustAHuman-xD JustAHuman-xD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JustAHuman-xD
Copy link
Contributor

I assume the update to mock Bukkit allows us to do this in testing then?

@WalshyDev
Copy link
Member

Yep, this was implemented in like 1.19 or something of MockBukkit

@WalshyDev WalshyDev merged commit bcfbd3a into Slimefun:master Jan 17, 2024
15 checks passed
@J3fftw1 J3fftw1 deleted the fix/slimefun-block-turning-into-vanilla-block branch January 17, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Fix This Pull Request fixes an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants