Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dough to fix item stacking issue #4100

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Update dough to fix item stacking issue #4100

merged 1 commit into from
Jan 17, 2024

Conversation

WalshyDev
Copy link
Member

Description

Items currently won't stack due to random UUIDs being used on each load. This will fix that

Proposed changes

Update dough to include pr Slimefun/dough#246

Related Issues (if applicable)

Fixes #4097

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@WalshyDev WalshyDev requested a review from a team as a code owner January 17, 2024 10:24
@github-actions github-actions bot added the ✨ Fix This Pull Request fixes an issue. label Jan 17, 2024
Copy link
Contributor

Your Pull Request was automatically labelled as: "✨ Fix"
Thank you for contributing to this project! ❤️

Copy link

sonarcloud bot commented Jan 17, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Sfiguz7 Sfiguz7 merged commit f7b42a1 into master Jan 17, 2024
17 checks passed
@Sfiguz7 Sfiguz7 deleted the fix/item-stacking branch January 17, 2024 10:26
Copy link
Contributor

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 8e7b8cf6

https://preview-builds.walshy.dev/download/Slimefun/4100/8e7b8cf6

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Fix This Pull Request fixes an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stacking items that are head
3 participants