Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix another bug with interaction fix and add more interaction tests #4090

Merged
merged 3 commits into from
Jan 14, 2024

Conversation

WalshyDev
Copy link
Member

@WalshyDev WalshyDev commented Jan 14, 2024

Description

Not all blocks will have an inventory, we missed a null check.
MockBukkit didn't catch as we can't check for viewers today :/

Proposed changes

  • Adds a null check to inventory closing in block break.
  • Adds basic item interaction and basic block interaction tests

Related Issues (if applicable)

https://pastebin.com/UiCbddCm

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

Not all blocks will have an inventory, we missed a null check.
MockBukkit didn't catch as we can't check for viewers today :/
Basic item interaction and basic block interaction tests
@WalshyDev WalshyDev requested a review from a team as a code owner January 14, 2024 05:14
@github-actions github-actions bot added the 🧹 Chores Refactoring / Cleanup. label Jan 14, 2024
Copy link
Contributor

Your Pull Request was automatically labelled as: "🧹 Chores"
Thank you for contributing to this project! ❤️

Copy link
Contributor

github-actions bot commented Jan 14, 2024

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 4d0f6712

https://preview-builds.walshy.dev/download/Slimefun/4090/4d0f6712

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

@WalshyDev
Copy link
Member Author

Tested a few items and blocks in game, all looks good this time around.

Sfiguz7
Sfiguz7 previously approved these changes Jan 14, 2024
@Sfiguz7 Sfiguz7 self-assigned this Jan 14, 2024
Copy link
Contributor

@J3fftw1 J3fftw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just incorrect docs

Copy link

sonarcloud bot commented Jan 14, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

18 New issues
0 Security Hotspots
71.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@WalshyDev WalshyDev merged commit 1fb27b9 into master Jan 14, 2024
16 checks passed
@WalshyDev WalshyDev deleted the chore/more-interaction-tests branch January 14, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 Chores Refactoring / Cleanup.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants