-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix another bug with interaction fix and add more interaction tests #4090
Conversation
Not all blocks will have an inventory, we missed a null check. MockBukkit didn't catch as we can't check for viewers today :/
Basic item interaction and basic block interaction tests
Your Pull Request was automatically labelled as: "🧹 Chores" |
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/4090/4d0f6712
|
Tested a few items and blocks in game, all looks good this time around. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just incorrect docs
...thub/thebusybiscuit/slimefun4/implementation/listeners/TestSlimefunItemInteractListener.java
Outdated
Show resolved
Hide resolved
...thub/thebusybiscuit/slimefun4/implementation/listeners/TestSlimefunItemInteractListener.java
Outdated
Show resolved
Hide resolved
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 18 New issues |
Description
Not all blocks will have an inventory, we missed a null check.
MockBukkit didn't catch as we can't check for viewers today :/
Proposed changes
Related Issues (if applicable)
https://pastebin.com/UiCbddCm
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values