Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backpack IDs not incrementing #4081

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

WalshyDev
Copy link
Member

Description

Fixes backpack IDs not incrementing unless the server is closed.

Proposed changes

The ID increment code was still reading the config file, updated this to rely on PlayerData. Made the next ID now be the backpack size. Created a new test to validate behaviour.

Related Issues (if applicable)

Fixes #4080

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@WalshyDev WalshyDev requested a review from a team as a code owner January 7, 2024 03:06
@github-actions github-actions bot added the ✨ Fix This Pull Request fixes an issue. label Jan 7, 2024
Copy link
Contributor

github-actions bot commented Jan 7, 2024

Your Pull Request was automatically labelled as: "✨ Fix"
Thank you for contributing to this project! ❤️

Copy link

sonarcloud bot commented Jan 7, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

9 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Jan 7, 2024

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 1953aa09

https://preview-builds.walshy.dev/download/Slimefun/4081/1953aa09

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

@WalshyDev WalshyDev merged commit 158c6ee into master Jan 7, 2024
17 checks passed
@WalshyDev WalshyDev deleted the fix/backpack-id-not-incrementing branch January 7, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Fix This Pull Request fixes an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backpacks don't increment number
3 participants