-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
temporarily diable senstive blocks check #4077
temporarily diable senstive blocks check #4077
Conversation
Your Pull Request was automatically labelled as: "✨ Fix" |
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/4077/ca7f1a14
|
should we keep these enabled for 1.19+ servers? and figure out other solutions for lower versions later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunate but necessary
src/main/java/io/github/thebusybiscuit/slimefun4/implementation/listeners/BlockListener.java
Outdated
Show resolved
Hide resolved
…n/listeners/BlockListener.java
The reason for disabling is the crashes and performance issues caused, these are a problem on 1.19+ servers |
The version check is simple to fix. The main issue I care about is the crashing servers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I accidentally clicked leave a comment not approve whoops
alright i forget about the crash reports earlier |
Description
This PR temporarily disables the senstive blocks check added in #4050.
This will now rebreak these issues #3831 #3182
Proposed changes
commented out the code added in #4050
Related Issues (if applicable)
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values