Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporarily diable senstive blocks check #4077

Merged

Conversation

J3fftw1
Copy link
Contributor

@J3fftw1 J3fftw1 commented Jan 3, 2024

Description

This PR temporarily disables the senstive blocks check added in #4050.
This will now rebreak these issues #3831 #3182

Proposed changes

commented out the code added in #4050

Related Issues (if applicable)

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@J3fftw1 J3fftw1 requested a review from a team as a code owner January 3, 2024 19:05
@github-actions github-actions bot added the ✨ Fix This Pull Request fixes an issue. label Jan 3, 2024
Copy link
Contributor

github-actions bot commented Jan 3, 2024

Your Pull Request was automatically labelled as: "✨ Fix"
Thank you for contributing to this project! ❤️

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: ca7f1a14

https://preview-builds.walshy.dev/download/Slimefun/4077/ca7f1a14

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

@ybw0014
Copy link
Contributor

ybw0014 commented Jan 3, 2024

should we keep these enabled for 1.19+ servers? and figure out other solutions for lower versions later.

JustAHuman-xD
JustAHuman-xD previously approved these changes Jan 3, 2024
Copy link
Contributor

@JustAHuman-xD JustAHuman-xD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunate but necessary

@JustAHuman-xD
Copy link
Contributor

should we keep these enabled for 1.19+ servers? and figure out other solutions for lower versions later.

The reason for disabling is the crashes and performance issues caused, these are a problem on 1.19+ servers

@WalshyDev
Copy link
Member

should we keep these enabled for 1.19+ servers? and figure out other solutions for lower versions later.

The version check is simple to fix. The main issue I care about is the crashing servers.

Copy link
Contributor

@JustAHuman-xD JustAHuman-xD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I accidentally clicked leave a comment not approve whoops

@ybw0014
Copy link
Contributor

ybw0014 commented Jan 3, 2024

alright i forget about the crash reports earlier

@WalshyDev WalshyDev merged commit e339503 into Slimefun:master Jan 3, 2024
14 checks passed
@J3fftw1 J3fftw1 deleted the fix/disable-senstive-blocks-check branch January 3, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Fix This Pull Request fixes an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants