Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 3677 #3678

Merged
merged 5 commits into from
Oct 4, 2022
Merged

fix 3677 #3678

merged 5 commits into from
Oct 4, 2022

Conversation

J3fftw1
Copy link
Contributor

@J3fftw1 J3fftw1 commented Sep 30, 2022 •
edited
Loading

Description

fixes 3677

Proposed changes

added mangrove to woodcutting android

Related Issues (if applicable)

Resolves #3677

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.14.* - 1.19.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@J3fftw1 J3fftw1 requested a review from a team as a code owner September 30, 2022 18:57
@J3fftw1
Copy link
Contributor Author

J3fftw1 commented Sep 30, 2022

oh wait this tag doesnt fit this tree dont merge yet

@J3fftw1
Copy link
Contributor Author

J3fftw1 commented Sep 30, 2022

someone give me a better name for the tag thanks

@svr333
Copy link
Member

svr333 commented Oct 1, 2022 •
edited
Loading

Im not sure what its even for
blocks the mangrove can grow on?

nvm just read the comment

@svr333
Copy link
Member

svr333 commented Oct 1, 2022

what about something like MANGROVE_BASE_BLOCKS / MANGROVE_ROOT_BLOCKS

svr333
svr333 approved these changes Oct 2, 2022
View reviewed changes
Copy link
Member

@svr333 svr333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@variananora variananora mentioned this pull request Oct 3, 2022
Closed
4 tasks
@J3fftw1 J3fftw1 changed the title fix 3577 fix 3677 Oct 3, 2022
@svr333 svr333 added the hacktoberfest-accepted Manual override to accept a PR for Hacktoberfest label Oct 3, 2022
TheBusyBiscuit
TheBusyBiscuit approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@TheBusyBiscuit TheBusyBiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you

@TheBusyBiscuit TheBusyBiscuit merged commit 7b9d769 into Slimefun:master Oct 4, 2022
@J3fftw1 J3fftw1 deleted the fix-3577 branch October 4, 2022 08:53
@J3fftw1
Copy link
Contributor Author

J3fftw1 commented Oct 4, 2022 •
edited
Loading

@svr333 thanks for the hacktoberfest accepted but it sadly doesnt count made it a few hours to early

edit:
it did count apparently, maybe time zone luck :D https://r2-sharex.j3fftw.dev/file/2022/09/a7ce9780-9d56-44e7-b3c9-99ad6689db1b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svr333 svr333 svr333 approved these changes

@TheBusyBiscuit TheBusyBiscuit TheBusyBiscuit approved these changes

Assignees

@TheBusyBiscuit TheBusyBiscuit

@svr333 svr333

Labels
hacktoberfest-accepted Manual override to accept a PR for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug SlimeFun Android glitch
3 participants
@J3fftw1 @svr333 @TheBusyBiscuit