Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.19 compatibility #3585

Merged
merged 12 commits into from
Jun 11, 2022
Merged

1.19 compatibility #3585

merged 12 commits into from
Jun 11, 2022

Conversation

TheBusyBiscuit
Copy link
Member

Description

This is a continuation of @J3fftw1's PR #3577.
All credit goes to him, this intermediate PR is just for some basic todos like README updates and bumping the dough version.

@TheBusyBiscuit TheBusyBiscuit requested review from a team as code owners June 11, 2022 10:14
@github-actions
Copy link
Contributor

Pro Tip!
You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️

Branch naming convention Label
feature/** 🎈 Feature
fix/** ✨ Fix
chore/** 🧹 Chores
api/** 🔧 API
performance/** 💡 Performance Optimization
compatibility/** 🤝 Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

@TheBusyBiscuit TheBusyBiscuit added the 🎮 Game Update This pull request adds compatibility with a new version of Minecraft. label Jun 11, 2022
@TheBusyBiscuit
Copy link
Member Author

✔️ Alright, I tested this and it seems to work very well on Paper's experimental 1.19 build 6.

I also finished fixing up the rest of the prior PR and updating assets like the readme, issue template and changelog.
This is ready to be merged from my point of view 👍🏻

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@WalshyDev WalshyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, let's ship it!

@TheBusyBiscuit
Copy link
Member Author

🚀 No need to wait for our Sfiguz

@TheBusyBiscuit TheBusyBiscuit merged commit 2c4f886 into master Jun 11, 2022
@TheBusyBiscuit TheBusyBiscuit deleted the major/1.19 branch June 11, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎮 Game Update This pull request adds compatibility with a new version of Minecraft.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants