Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local CSS #540

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Local CSS #540

wants to merge 3 commits into from

Conversation

ShadowByteStudio
Copy link

Added --local-css flag to replace the remote CSS link with local CSS for azure pipelines.

ksuther
ksuther reviewed Sep 20, 2023
View reviewed changes
Copy link
Contributor

@ksuther ksuther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, and sorry for taking forever to look at it! Left a comment about including link if this option is enabled.

lib/slather/coverage_service/html_output.rb
@@ -250,6 +250,9 @@ def generate_html_template(title, is_index, is_file_empty)
doc.head {
doc.title "#{title} - Slather"
doc.link :href => css_path, :media => "all", :rel => "stylesheet"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If local_css is enabled should doc.link be skipped?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksuther ksuther ksuther left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShadowByteStudio @ksuther