Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump xcodeproj to 1.21 #502

Merged
merged 4 commits into from
Sep 29, 2021

Conversation

adamyanalunas
Copy link
Contributor

@adamyanalunas adamyanalunas commented Sep 24, 2021

👋 Hi there!

Between CocoaPods and Fastlane using more recent versions of xcodeproj I’m blocked from using Slather 2.7.1, the latest release.

This PR just bumps Slather’s xcodeproj dependency from 1.7 to 1.21. Easy peasy.

Let me know if there’s documentation or versioning or anything else I should add here. Thanks!

@ksuther
Copy link
Contributor

ksuther commented Sep 28, 2021

Thanks for the PR! This conflicts because of another dependency update. Can you rebase the branch?

Also, should the dependency version be 1.21.0 or 1.21? I'm not sure if 1.21.0 will lock it to 1.21.x versions or not.

@adamyanalunas adamyanalunas changed the title Bump xcodeproj to 1.21.0 Bump xcodeproj to 1.21 Sep 29, 2021
@adamyanalunas
Copy link
Contributor Author

Good callout on locking to minor, not patch. Thanks, @ksuther!

Change made, conflict resolved 👍

@ksuther ksuther merged commit 7cefdb5 into SlatherOrg:master Sep 29, 2021
@ksuther
Copy link
Contributor

ksuther commented Sep 29, 2021

Thank you!

@adamyanalunas adamyanalunas deleted the bump_xcodeproj_to_1.21.0 branch September 29, 2021 20:38
@adamyanalunas
Copy link
Contributor Author

Thanks, @ksuther! No rush but any idea on a timeline for a release that contains this change?

@adamyanalunas adamyanalunas restored the bump_xcodeproj_to_1.21.0 branch September 29, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants