Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for xcode scheme containing multiple testable targets. #275

Merged
merged 2 commits into from
Mar 30, 2017

Conversation

serges147
Copy link

Currently (in 2.3.0) it's impossible to slather multiple build action entries of a scheme - only the first one is processed.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 95.047% when pulling 042dbbf on serges147:master into e56129a on SlatherOrg:master.

2) Added new “fixturesTestsSecond” and “aggregateFixturesTests” schemes - to test multitarget schemes;
3) Added new test “it should find multiple unique paths for a scheme with serveral buildable/testable products”.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 95.273% when pulling db78707 on serges147:master into e56129a on SlatherOrg:master.

@serges147
Copy link
Author

I believe that it will fix issues#96

@serges147
Copy link
Author

Please let me know if I need to do some extra steps so that my pull request will be considered - I'm bit new-baby to world of open-source contribution ;) Thanks!

@ksuther
Copy link
Contributor

ksuther commented Feb 9, 2017

This looks reasonable to me. I tried it out on my own project and it included all the test targets without any complaint.

@serges147
Copy link
Author

@ksuther , can you please merge this PR as well? Our project really depends on this - we have one cumulative (workspace) scheme (called "All_Unit_Tests") which includes several test targets from different projects included into the workspace. So, we are looking forward get this in upcoming release as well. Thanks!

@ksuther ksuther merged commit c035bff into SlatherOrg:master Mar 30, 2017
@ksuther
Copy link
Contributor

ksuther commented Mar 30, 2017

Done, thanks for the changes!

I keep thinking that slather could use a reworked system for finding and matching binaries, which might involve throwing out some of this. Better to have it added now though, and having the tests for the future is valuable as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants