Fix bad UTF-8 encoding issues #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, the html report was displaying this: // Copyright (c) 2013-2016 C��dric Luthi. All rights reserved. After this commit, the html report is displaying this: // Copyright (c) 2013-2016 Cédric Luthi. All rights reserved. I added a 🌟 (Glowing Star, U+1F31F) in the fixtures to make sure it’s property encoded. The problem was that valid UTF-8 was interpreted as "binary" and re-encoded as UTF-8, producing invalid output.
eliperkins
approved these changes
Oct 20, 2016
| @@ -3,7 +3,7 @@ | |||
| // fixtures | |||
| // | |||
| // Created by Mark Larsen on 6/24/14. | |||
| // Copyright (c) 2014 marklarr. All rights reserved. | |||
| // Copyright (c) 2014 marklarr 🌟. All rights reserved. | |||
|
Ping. |
|
Thanks for the pull request. |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, the html report was displaying this:
// Copyright (c) 2013-2016 C��dric Luthi. All rights reserved.
After this commit, the html report is displaying this:
// Copyright (c) 2013-2016 Cédric Luthi. All rights reserved.
I added a 🌟 (Glowing Star, U+1F31F) in the fixtures to make sure it’s property encoded.
The problem was that valid UTF-8 was interpreted as "binary" and re-encoded as UTF-8, producing invalid output.