Support for specifying llvm-cov source files #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value should be preserved if it was passed in using command line arguments.
We were seeing the following showing up as a new file: ``` warning The file '/Users/ci/.ccache/tmp/CALayer-KI.stdout.macmini08.92540.QAQaxt.mi' isn't covered. ```
- Uses ruby’s Dir.glob for maximum flexibility and easy lookup. - Files are passed to llvm-cov to speed up processing. - If ignore patterns are also given, they are applied before the files are passed to llvm-cov so ignored files are not processed at all. - If multiple binaries are processed, the already processed files get excluded during subsequent runs, speeding up processing, if there is a lot of overlap between the binaries.
Fixes tests.
If we provide a single line to llvm-cov, the usual first line pathname output is skipped, and we instead immediately get the source code.
Can also handle made up paths in tests.
|
Ah, looks like I addressed the same issue as 988c0b1#diff-db3aebc6a6233da7b7bca5b646c4fa09R325. Will resolve the conflict. |
Conflicts: lib/slather/project.rb
|
This is great 👍 — thanks a lot for the contribution 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some issues we had to overcome to make Slather work (well) with our test setup at PSPDFKit.
See the commit message for details but the essential part is:
For our relatively complex test setup where we have multiple test projects covering multiple libraries with quite a bit of overlap between coverage, this resulted in the processing time going down from about 2 minutes to around 30 seconds.
The new option does not apply to gcov files. I haven't looked closely, but from glancing ove the implementation it seems like it would not make any sense there.