Fix for not being able to find some xctest bundles #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update xctest_bundle using the search_for variable. Before xctest_bundle would be set to the first xctest bundle in the build products, even if we're searching for a different test target. For example, a command such as: slather coverage --scheme MyScheme --binary-basename BTests --html MyProject.xcodeproj Would pick ATests over BTests if there are test targets for ATests and BTests, because ATests would always be the first path returned in the initial assignment.
|
Looks like CI failed from an error in curl. |
|
I triggered a rerun, but there seems to be one legitimate failure. |
That way if there's no match for the search term we still fall back to the first found bundle.
|
Great, could you please add an entry to the changelog, then this is good to go! |
|
Done, thanks! |
|
Awesome, thanks a lot for the contribution! 🎉 |
neonichu
added a commit
that referenced
this pull request
Mar 16, 2016
Fix for not being able to find some xctest bundles
keatongreve
pushed a commit
to keatongreve/slather
that referenced
this pull request
Mar 23, 2016
Fix for not being able to find some xctest bundles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update xctest_bundle using the search_for variable. Before xctest_bundle would be set to the first xctest bundle in the build products, even if we're searching for a different test target.
For example, a command such as:
slather coverage --scheme MyScheme --binary-basename BTests --html MyProject.xcodeproj
Would pick ATests over BTests if there are test targets for ATests and BTests, because ATests would always be the first path returned in the initial assignment.