Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binary_basename configuration option #128

Merged
merged 2 commits into from
Feb 4, 2016

Conversation

neonichu
Copy link
Member

Makes it easier to select the right binary to consider for code coverage computation. Instead of having to pass the full path to your framework, you can just configure its basename and it will be found ✨

Makes it easier to select the right binary to consider for code coverage
computation. Instead of having to pass the full path to your framework,
you can just configure its basename and it will be found ✨
@stepheng
Copy link

Would it be possible to update this so --binary-basename can be passed from the command-line instead of requiring the .slather.yml. Thanks.

@neonichu
Copy link
Member Author

neonichu commented Feb 3, 2016

Yah, I think adding a --binary-basename makes sense.

@larslockefeer
Copy link

Small question: How does this relate to the binary_file option added by @viteinfinite in #92? Wouldn't it be enough to allow passing in just a name as this parameter instead of a path and use this value to find the matching binary file?

Our current invocation of slather is:

slather coverage --input-format profdata --cobertura-xml --scheme $appScheme --binary-file "$COVERAGE_BASE"/CodeCoverage/$appName/Products/Debug-iphonesimulator/$appName.app/$appName $projectFile

... while I think that this should be enough:

slather coverage --input-format profdata --cobertura-xml --scheme $appScheme --binary-file $appName $projectFile

@neonichu
Copy link
Member Author

neonichu commented Feb 4, 2016

I think it makes sense to offer both options, —binary-file would override any automatism of slather (e.g. for working around cases where Xcode changes paths, like 7.3 does), while —binary-basename would be the more common choice where one just wants to pick a binary with a specific name, but the automatic resolution works.

@neonichu
Copy link
Member Author

neonichu commented Feb 4, 2016

:shipit:

neonichu added a commit that referenced this pull request Feb 4, 2016
Add `binary_basename` configuration option
@neonichu neonichu merged commit 9250dd1 into SlatherOrg:master Feb 4, 2016
@neonichu neonichu deleted the add-binary_basename-option branch February 4, 2016 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants