fix: thread starvation from non-constant time method call #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sychic
reviewed
Sep 20, 2024
| outboundRoomQueue.clear() | ||
| printDevMessage("closed room queue world load", "dungeonws") | ||
| outboundRoomQueue.close() | ||
| outboundRoomQueueTask?.cancel() |
There was a problem hiding this comment.
Not sure if this does exactly what you expect it to since this will simply wait until it's fully finished executing before cancelling.
src/main/kotlin/gg/skytils/skytilsmod/listeners/DungeonListener.kt
Outdated
Show resolved
Hide resolved
checking size/not empty on ConcurrentLinkedQueue is not constant time and requires either looping or grabbing first element
My-Name-Is-Jeff
force-pushed
the
fix/wsstarve
branch
from
126990e
to
c30b17f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checking size/not empty on ConcurrentLinkedQueue is not constant time and requires either looping or grabbing first element
supersedes #501