fix: ice fill solves slowly #495
Conversation
| starts.second.offset(direction, 5), | ||
| //seven: -14 72 -89 | ||
| starts.third.offset(direction, 7), | ||
| ) |
There was a problem hiding this comment.
What's the point of hard coding the beginning and ends like this? Does it actually improve the performance significantly?
There was a problem hiding this comment.
Since it's been months when I originally added it, idk exactly how much the performance increased, however it was definitely noticable from what I remember. As before it scanned a 51x51x3 area, so about 7803 blocks and that times 2 (So 15606 blocks), since it also scans all the blocks below it. You could probably optimize the original code enough for it to be usable but I couldn't be bothered.
There was a problem hiding this comment.
Alright, just checking since hard coding can mean that updates will break it in the future. Personally I'd prefer scanning (definitely with a more optimized area) over hard coding but if it works, that's fine.
ice fill go brrrr