Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked boss timer a bit and many things #419

Merged
merged 9 commits into from
Oct 10, 2023
Merged

Reworked boss timer a bit and many things #419

merged 9 commits into from
Oct 10, 2023

Conversation

AzuredBlue
Copy link
Contributor

@AzuredBlue AzuredBlue commented Sep 23, 2023

  • Fixed Terracotta time in M6 (maybe)
  • Improved Simon Says Solver
  • Fixed noChildLeftBehind (GUI name is different)
  • Reworked M7 Boss Timer (Added a Terminals Split, changed messages to more accepted split messages)
  • Allowed to change box starred mobs color
  • Improved prevent cursor reset to not always reset
    = Hide Tooltip in Melody Terminal instead of Maze (Good night maze, not coming back)
    = Fixed legion display being wrong sometimes
  • Removed Portal Entry Timer and Hide Pet Nametags (Portal is now instant and you can hide pet nametags in pet settings)

@pull-request-quantifier-deprecated

This PR has 220 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Large
Size       : +98 -122
Percentile : 62%

Total files changed: 13

Change summary by file extension:
.java : +9 -5
.kt : +89 -117

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@AzuredBlue
Copy link
Contributor Author

i think its done
making simon says boxes more accurately cover the button would be nice but thats too much effort
same with garden features

AzuredBlue and others added 9 commits October 9, 2023 20:41
fixed terracotta time maybe
fixed noChildLeftBehind
removed portal entry timer and hide pet nametags
reworked m7 boss timer
replaced maze with melody when hiding the tooltip
Also made trapper thing only work in the farming island
Watchdog has UUID v4, nicked players have uuid v1
Now works with chat messages and an essentials notification.
Also pretty sure it didnt work when you went offline
Remove unneeded variable guiWasNotNull
@My-Name-Is-Jeff My-Name-Is-Jeff merged commit 091a3c2 into Skytils:1.x Oct 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants