[BPK-971] Upgrade webpack deps #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `--open` flag to automatically open web browser for docs dev.
matthewdavidson
force-pushed
the
bpk-971-webpack-deps
branch
from
4612b82
to
a002323
Compare
Generated by 🚫 dangerJS |
| @@ -32,7 +32,7 @@ | |||
| "build": "npm run build:tokens && npm run build:svgs && lerna run build && (cd ./native && npm run link)", | |||
| "storybook": "start-storybook -p 9001", | |||
| "sassdoc": "sassdoc {packages/bpk-mixins/src/**/*,packages/bpk-svgs/dist/*,packages/bpk-tokens/tokens/base.default}.scss -d dist/sassdoc -v --strict --debug", | |||
| "docs": "webpack-dev-server", | |||
| "docs": "webpack-dev-server --open", | |||
|
I've tested storybook dev ( |
k0nserv
approved these changes
Oct 25, 2017
shaundon
reviewed
Oct 25, 2017
| @@ -63,23 +60,17 @@ | |||
| /******/ __webpack_require__.p = ""; | |||
| /******/ | |||
| /******/ // Load entry module and return exports | |||
| /******/ return __webpack_require__(__webpack_require__.s = 1); | |||
| /******/ return __webpack_require__(__webpack_require__.s = 0); | |||
There was a problem hiding this comment.
I couldn't find in the links you posted where this change comes from - what does it do?
There was a problem hiding this comment.
extract-text-webpack-plugin added sorting https://github.com/webpack-contrib/extract-text-webpack-plugin/blob/master/CHANGELOG.md#300-rc1-2017-07-07
|
@k0nserv me too - for comparison, here is CRA's webpack 3 upgrade PR facebook/create-react-app#2574 |
shaundon
approved these changes
Oct 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the many PR's aimed at upgrading dependencies in the backpack monorepo. I focus on updating webpack based dependencies. Here are the list of changelogs:
Also added
--openflag to automatically open web browser for docs dev.