Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progressDeadlineSeconds #63

Open
maruina opened this issue Apr 19, 2021 · 2 comments
Open

Add progressDeadlineSeconds #63

maruina opened this issue Apr 19, 2021 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@maruina
Copy link
Contributor

maruina commented Apr 19, 2021

To make sure the operator doesn't get stuck in an infinite loop, we need a safeguard mechanism. We want this to be eventual consistent, because there might be a delay in ArgoCD (it might be down, or unable to sync for a time window).

We can use the progressDeadlineSeconds concept as seen in https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.19/#deploymentspec-v1-apps and https://docs.flagger.app/usage/how-it-works

@maruina maruina added the enhancement New feature or request label Apr 19, 2021
@maruina maruina added this to the Milestone 2 milestone Apr 19, 2021
@maruina
Copy link
Contributor Author

maruina commented May 7, 2021

@maruina
Copy link
Contributor Author

maruina commented Jan 9, 2022

Considering how ArgoCD support retries with backoff, as per https://argo-cd.readthedocs.io/en/stable/operator-manual/application.yaml

    # The retry feature is available since v1.7
    retry:
      limit: 5 # number of failed sync attempt retries; unlimited number of attempts if less than 0
      backoff:
        duration: 5s # the amount to back off. Default unit is seconds, but could also be a duration (e.g. "2m", "1h")
        factor: 2 # a factor to multiply the base duration after each failed retry
        maxDuration: 3m # the maximum amount of time allowed for the backoff strategy

we can tune ArgoCD to retry how many times we need with the appropriate backoff.

This behavior makes the ProgressDeadline feature less urgent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant