Skip to content

Fix issue where empty string in a dropdown is displayed as "empty". #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThomasRemmery merged 3 commits into from
May 20, 2026
Merged

Fix issue where empty string in a dropdown is displayed as "empty". #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
470c0c0
Fix issue where empty string in a dropdown is displayed as "empty".
ThomasRemmery May 20, 2026
2075af1
fix: use non-empty raw value for empty display options
Copilot May 20, 2026
84b3d6b
fix: keep empty dropdown option visually empty
Copilot May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions InteractiveAutomationToolkit/Components/RawValueMapping.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ internal class RawValueMapping<T>

public bool TryGetByRawValue(string rawValue, out T value)
{
if (String.IsNullOrEmpty(rawValue))
if (rawValue == null)
{
value = default;
return false;
Expand Down Expand Up @@ -118,7 +118,7 @@ private static string CleanDisplayValue(string displayValue)
{
if (String.IsNullOrEmpty(displayValue))
{
return "empty";
return "\u200B";
}
Comment on lines 118 to 122
Copy link
Copy Markdown
Contributor

Copilot AI May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented in 2075af1. Empty/null display values now map to a non-empty raw value ("-") so selections can be serialized and parsed back correctly, and I added a focused test (DropDown_HandleEmptyOption) to cover the behavior.


var sb = new StringBuilder();
Expand Down
16 changes: 16 additions & 0 deletions InteractiveAutomationToolkitTests/ComponentTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,22 @@ public void DropDown_HandlePipeChar()
Assert.AreEqual("--3", dropDown.BlockDefinition.InitialValue);
}

[TestMethod]
public void DropDown_HandleEmptyOption()
{
DropDown dropDown = new DropDown(new[] { String.Empty, "|" });
Assert.AreEqual(String.Empty, dropDown.Selected);
Assert.AreEqual("\u200B", dropDown.BlockDefinition.InitialValue);

dropDown.Selected = "|";
Assert.AreEqual("|", dropDown.Selected);
Assert.AreEqual("-", dropDown.BlockDefinition.InitialValue);

dropDown.Selected = String.Empty;
Assert.AreEqual(String.Empty, dropDown.Selected);
Assert.AreEqual("\u200B", dropDown.BlockDefinition.InitialValue);
}

[TestMethod]
public void GenericDropDown_HandlePipeChar()
{
Expand Down
Loading