Add generic TreeView<T> control#50
Merged
ThomasRemmery merged 8 commits into10.5.5.Xfrom Oct 23, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces a generic TreeView<T> control that extends the existing non-generic TreeView implementation. The generic version allows developers to attach custom metadata of any type to tree view items, making it easier to work with domain objects while maintaining the UI tree structure.
Key changes:
- Addition of generic
TreeViewItem<T>wrapper that associates custom values with tree view items - New
TreeView<T>control extending a newly createdTreeViewBaseabstract class - Refactoring of the original
TreeViewto also extendTreeViewBasefor code reuse - Introduction of interface hierarchy (
ITreeViewBase,ITreeView,ITreeView<T>) to support both implementations
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| GenericTreeViewTests.cs | Comprehensive test suite for the new TreeView<T> control covering constructors, item navigation, state management, and equality operations |
| TreeViewItem.cs | Generic wrapper class that associates a value of type T with a TreeViewItem instance |
| TreeViewBase.cs | Abstract base class extracting common functionality for both generic and non-generic tree view controls |
| TreeView.cs | Refactored to extend TreeViewBase and implement ITreeView, with improved implementation using a lookup table and queue-based traversal |
| ITreeViewBase.cs | Base interface defining common tree view operations like expand, collapse, and cache updates |
| ITreeView.cs | Interface definitions for both non-generic (ITreeView) and generic (ITreeView<T>) tree view contracts |
| GenericTreeView.cs | Implementation of the generic TreeView<T> control with support for typed tree view items and values |
| UiResultsExtensions.cs | Updated extension methods to accept TreeViewBase instead of TreeView for broader compatibility |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Simplified state management by removing redundant variables and dynamically creating `changedItems` in `RaiseResultEvents`. Replaced `List` with `ISet` for better performance in key operations. Streamlined list initialization using LINQ for improved readability and reduced boilerplate code. Removed unused `Skyline.DataMiner.Automation` namespace to clean up dependencies. Refactored `LoadResult` and event handling logic for consistency and efficiency. Reformatted LINQ queries for better readability. Overall, these changes enhance maintainability, performance, and clarity.
|
ThomasRemmery
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.