Fix minimum DataMiner version handling in CatalogInformation - #130
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
janstaelensskyline
changed the title
janstaelensskyline
changed the title
janstaelensskyline
changed the title
MichielOda
approved these changes
Aug 19, 2026
jarno-lernou-skyline
approved these changes
Aug 19, 2026
jarno-lernou-skyline
left a comment
jarno-lernou-skyline
left a comment
Member
There was a problem hiding this comment.
Note, only tested my use case, but it works. You cannot see the warning anymore over here: Penalty Box Monitoring | Catalog | dataminer.services
This was referenced Aug 27, 2026
Bump the all-dependencies group with 1 update
SkylineCommunications/SLC-AS-SendEmailWhenErrorInLog#5
Closed
Closed
This was referenced Sep 9, 2026
Bump the all-dependencies group with 1 update
SkylineCommunications/SLC-AS-SendEmailWhenErrorInLog#9
Open
Closed
Closed
This was referenced Sep 16, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #129
Adds minimum DataMiner version handling to CatalogInformation so the Webpages/Public deployment notice is only added when required. Includes coverage for high, low, and unspecified minimum versions, wires the value through the SDK targets, and keeps the NuGet.Frameworks runtime fix required by the test matrix.