AddNodesTests added. - #273
Open
EdibSU wants to merge 12 commits into
Open
Conversation
"Added" resource manager simulation.
Skyline Quality Gate: ✅ Passed
SonarCloud: new-code dashboard for See the Actions run for full logs. |
EdibSU
marked this pull request as ready for review
August 13, 2026 12:31
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request extends the simulated/in-memory Resource Manager behavior used by the unit-testing harness, and updates/expands the integration test suite to validate node graph, tentative job behavior, resource eligibility, and concurrency/quarantine scenarios against both real and simulated connections.
Changes:
- Implemented in-memory handling for
GetEligibleResourcesMessageplus additional reservation conflict/quarantine simulation inResourceManagerStore. - Updated and added workflow/job/node graph tests to create their own data (instead of relying on pre-existing objects) and to cover new edge cases.
- Expanded RST resource tests to run on simulated connections by leveraging the in-memory Resource Manager store.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| DevPack.UnitTesting/Stores/ResourceManagerStore.cs | Adds eligibility resolution and enhances reservation update/quarantine/conflict simulation for the in-memory Resource Manager. |
| DevPack.Tests/Workflow/Workflows/BasicTests.cs | Makes workflow read tests self-contained by creating a workflow before verifying read-by-id/name behavior. |
| DevPack.Tests/Workflow/Jobs/TentativeStateTests.cs | Adds tentative-job update coverage, mandatory settings cases, and a failure case for past timings. |
| DevPack.Tests/Workflow/Jobs/NodeGraphTests.cs | Adds additional node graph scenarios across job states (draft/tentative/confirmed/completed). |
| DevPack.Tests/Workflow/Jobs/JobDuplicateTests.cs | Adds coverage ensuring job duplication does not copy error state. |
| DevPack.Tests/RST/Resources/ResourceConcurrencyTests.cs | Adds a concurrency-downgrade scenario that validates quarantine behavior for overlapping tentative reservations. |
| DevPack.Tests/RST/Resources/EligibleResourceTests.cs | Removes “real DMA only” skipping and adds more assignment/eligibility coverage for simulated connections. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Author
|
AB#45388 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AB#45388