Reconcile property attachments against stored names to prevent orphans on file setting removal - #269
Merged
JensVandewalle merged 2 commits intoAug 13, 2026
Conversation
…racking removed file settings Co-authored-by: JensVandewalle <102030104+JensVandewalle@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code based on review comment
Reconcile property attachments against stored names to prevent orphans on file setting removal
Aug 12, 2026
JensVandewalle
approved these changes
Aug 13, 2026
JensVandewalle
marked this pull request as ready for review
August 13, 2026 06:32
Copilot AI
added a commit
that referenced
this pull request
Aug 13, 2026
Co-authored-by: JensVandewalle <102030104+JensVandewalle@users.noreply.github.com>
JensVandewalle
added a commit
that referenced
this pull request
Aug 13, 2026
Co-authored-by: JensVandewalle <102030104+JensVandewalle@users.noreply.github.com>
JensVandewalle
added a commit
that referenced
this pull request
Aug 13, 2026
This reverts commit 3acaec0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a file setting was removed via
Remove,Clear, orSetPropertySettings, its attachments could be orphaned if the setting was never tracked inRemovedFileSettings(e.g., settings for unknown/deleted property definitions that were skipped during parse).Changes
SyncAttachments: Replaced theRemovedFileSettings-based orphan loop with aGetNames-based reconciliation — fetches all stored attachment names and deletes any not present in the expected set built from currentFileSettings. This covers all orphan sources unconditionally, not just explicitly removed in-memory settings.SyncAttachments(main loop): Removed thefilesToDeleteexplicit deletion loop. Reconciliation already deletes any attachment absent fromexpectedAttachments, making the per-setting delete pass redundant and a source of double-deletion.DeleteAttachments: Removed — no longer referenced.The expected set is still derived from
FileSettings[*].Files(includes pending uploads), so in-flight uploads are never incorrectly deleted and re-added settings retain their attachments.