Key stone#43
Closed
janstaelensskyline wants to merge 21 commits into
Closed
Conversation
MichielOda
requested changes
Apr 30, 2024
MichielOda
requested changes
May 3, 2024
MichielOda
requested changes
May 6, 2024
| fs.File.WriteAllText(topLevelFile, fileContent); | ||
| } | ||
|
|
||
| var packResult = dotnet.Run($"pack \"{shimmyPathForPackaging}/ExeShim.csproj\" --output \"{toolMetaData.OutputDirectory}\""); |
Member
There was a problem hiding this comment.
When the program name contains spaces, this eventually returns an error:
Maybe some early validation couldn't hurt as people tend to use spaces a lot? Then it will also be a clearer error message.
Member
Author
There was a problem hiding this comment.
I've sanitized the inputs instead of throwing errors for ease of use.
Member
|
Archiving this PR as it's currently not relevant anymore. Can be reopened or recreated when necessary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can already be reviewed. The remaining TODO will be done when Installer & Creator for dmapp's is adjusted to allow nugets as input.