Skip to content

Fix invalid reference when using DevPacks inside DevPacks with different versions#142

Merged
MichielOda merged 1 commit into
mainfrom
FixTransitiveIssue
Mar 9, 2026
Merged

Fix invalid reference when using DevPacks inside DevPacks with different versions#142
MichielOda merged 1 commit into
mainfrom
FixTransitiveIssue

Conversation

@MichielOda

Copy link
Copy Markdown
Member

This pull request refines how solution library NuGet packages are handled in the PackageReferenceProcessor. The main improvement is that solution library packages are now excluded from implicit DLL import directory references, which aligns with their special handling. Corresponding unit tests have been updated to reflect this new logic.

Changes to solution library package handling:

  • Updated logic in PackageReferenceProcessor.cs to exclude solution library NuGet packages from implicit DLL import directory references by checking with NuGetHelper.IsSolutionLibraryNuGetPackage.

Test updates:

  • Removed solution library package paths from ImplicitDllImportDirectoryReferences in ProcessAsyncTest_SolutionLibraries and ProcessAsyncTest_SolutionLibraries2 unit tests.
  • Cleaned up related test data and expected results for solution library packages in ProcessAsyncTest_SolutionLibraries2.
  • Minor formatting and comment adjustments for clarity in test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant