Skip to content

Improve SolutionLibraries Transitive Dependency handling#137

Merged
MichielOda merged 3 commits intoSkylineCommunications:mainfrom
ArneMaes0:dev/dev_packs_transitive_dependencies
Mar 4, 2026
Merged

Improve SolutionLibraries Transitive Dependency handling#137
MichielOda merged 3 commits intoSkylineCommunications:mainfrom
ArneMaes0:dev/dev_packs_transitive_dependencies

Conversation

@ArneMaes0
Copy link
Copy Markdown
Member

Pull Request Description

This PR ensures that dependencies of DevPacks (SolutionLibraries) are correctly resolved in automation scripts and handled appropriately during script packaging. In automation scripts, all dependencies of DevPacks are resolved and included, even if some dependencies are other DevPacks. During packaging, DevPack assemblies themselves are not included, as they are expected to already be present on the target system. Previously, DevPack dependencies were not reliably resolved, which could lead to missing assemblies in the final package.

Key Changes

  • Automation scripts now resolve and include all DevPack dependencies, even if some dependencies are other DevPacks.
  • During packaging, DevPack assemblies themselves are not included, as they should already be present on the system.
  • Added unit tests to validate DevPack dependency handling during script packaging.
  • Used four dummy DevPacks from the Skyline.DataMiner.Dev.Utils.DummySolutionLib repo to cover scenarios:
    • DevPack with no dependencies
    • DevPack depending on another DevPack
    • DevPack with a NuGet dependency (Newtonsoft.Json)
    • DevPack depending on a DevPack with a NuGet dependency

Impact

  • Automation scripts now reliably resolve and include all required DevPack and NuGet dependencies.
  • Script packaging excludes DevPack assemblies, ensuring only external dependencies are packaged.
  • Improved test coverage for DevPack dependency scenarios.

ArneMaes0 and others added 3 commits March 2, 2026 08:43
Refactored package name extraction for SolutionLibraries in AutomationScriptBuilder.
Updated NuGetHelper to process SolutionLibrary dependencies.
Added new test projects and cases to verify correct handling of SolutionLibrary NuGet packages and their dependencies, including custom and nested scenarios.
@MichielOda MichielOda changed the title Improve SolutionLibrary Transitive Depedency handling Improve SolutionLibraries Transitive Dependency handling Mar 4, 2026
@MichielOda MichielOda merged commit 65204f8 into SkylineCommunications:main Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants